Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Text.Parsec.Number #56

Merged
merged 27 commits into from
Jun 6, 2024
Merged

feat: Text.Parsec.Number #56

merged 27 commits into from
Jun 6, 2024

Conversation

leoslf
Copy link
Contributor

@leoslf leoslf commented Jun 5, 2024

Hi @sighingnow,

Thanks for bringing parsec to python!

I have made the following changes:

  • feat(Text.Parsec.Char): exposed satisfy from Text.Parsec.Char
  • refactor(Text.Parsec.Char): use satisfy accordingly
  • feat(Text.Parsec.Combinators): implemented between from Text.Parsec.Combinators
  • feat(Text.Parsec.Number) implemented {decimal,binary,octal,hexadecimal} from Text.Parsec.Number
  • ci: invoke test via coverage.py and show coverage with missing lines
  • ci: perform type checking via mypy
  • test: added tests for edge cases in existing code

Feel free to let me know if there's anything you would like to change or if there are any comments.

Best Regards,
Leo

@sighingnow
Copy link
Owner

@leoslf Thank you a lot for bringing new features to this repo!

@sighingnow sighingnow merged commit ca93663 into sighingnow:master Jun 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants